fix: empty ORLists now return false#1297
Open
TheBobBobs wants to merge 2 commits intoTagStudioDev:mainfrom
Open
fix: empty ORLists now return false#1297TheBobBobs wants to merge 2 commits intoTagStudioDev:mainfrom
TheBobBobs wants to merge 2 commits intoTagStudioDev:mainfrom
Conversation
TrigamDev
added
Status: Review Needed
Collaborator
|
While this might1 fix the specific symptom reported in #1287 this doesn't address the root cause of this issue, which is likely that Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an
ORListhas only invalid tags returnFalse.The default query is an empty
ORListso returnTrueif theORListcontained no elements before seperating tags.fixes #1287
Tasks Completed